_is_plugin_enabled() reads config from wrong path (HERMES_HOME mismatch) #2

New issue

Closed

opened 2026-06-10 10:28:27 +00:00 by glow · 0 comments

glow commented

2026-06-10 10:28:27 +00:00

Owner

Problem

_is_plugin_enabled() in __init__.py reads the config file from HERMES_HOME / "config.yaml":

hermes_home = os.environ.get("HERMES_HOME", "~/.hermes")
config_path = Path(hermes_home).expanduser() / "config.yaml"

When the plugin runs inside the gateway process, HERMES_HOME=/root/.hermes, so it reads /root/.hermes/config.yaml. But the agenda: config key (e.g. agenda.state_key: agenda) is only in /root/.hermes/profiles/canal1/config.yaml.

Since the config has no agenda: section at /root/.hermes/config.yaml, the function always falls through to the return True fail-open. This is a silent correctness issue — if someone explicitly disabled the plugin via profile config, it would be ignored.

## Problem `_is_plugin_enabled()` in `__init__.py` reads the config file from `HERMES_HOME / "config.yaml"`: ```python hermes_home = os.environ.get("HERMES_HOME", "~/.hermes") config_path = Path(hermes_home).expanduser() / "config.yaml" ``` When the plugin runs inside the gateway process, `HERMES_HOME=/root/.hermes`, so it reads `/root/.hermes/config.yaml`. But the `agenda:` config key (e.g. `agenda.state_key: agenda`) is only in `/root/.hermes/profiles/canal1/config.yaml`. Since the config has no `agenda:` section at `/root/.hermes/config.yaml`, the function always falls through to the `return True` fail-open. This is a silent correctness issue — if someone explicitly disabled the plugin via profile config, it would be ignored.

glow added the

bug

label

2026-06-10 10:28:27 +00:00

glow referenced this issue from a commit

2026-06-10 10:31:06 +00:00

fix: resolve 5 agenda-plugin issues — loading, cache keys, change detection, decisions, config path

glow closed this issue

2026-06-10 10:31:06 +00:00