Missing on_session_end hook — no cleanup on session end #3

New issue

Open

opened 2026-06-10 10:28:27 +00:00 by glow · 0 comments

glow commented

2026-06-10 10:28:27 +00:00

Owner

Problem

The plugin registers three hooks (pre_llm_call, post_tool_call, on_session_start) but does not register on_session_end.

When a session ends (user closes chat, timeout, disconnect), the agenda state remains in Sibyl's state_documents table with status: "active". Next session start detects the stale state and logs "Active agenda detected on session start" but there's no way to distinguish a fresh continuation from stale garbage.

Suggested fix

Add an on_session_end hook that checks the agenda status. If the status is still "active" and the session ending is not a clean handoff (e.g. user disconnected), mark it as status: "paused" or clear it entirely.

A safer approach: only clear if the agenda's session_id matches the ending session, to avoid stealing an agenda from a concurrent session.

## Problem The plugin registers three hooks (`pre_llm_call`, `post_tool_call`, `on_session_start`) but does **not** register `on_session_end`. When a session ends (user closes chat, timeout, disconnect), the agenda state remains in Sibyl's `state_documents` table with `status: "active"`. Next session start detects the stale state and logs "Active agenda detected on session start" but there's no way to distinguish a fresh continuation from stale garbage. ## Suggested fix Add an `on_session_end` hook that checks the agenda status. If the status is still "active" and the session ending is not a clean handoff (e.g. user disconnected), mark it as `status: "paused"` or clear it entirely. A safer approach: only clear if the agenda's `session_id` matches the ending session, to avoid stealing an agenda from a concurrent session.

glow added the

improvement

label

2026-06-10 10:28:27 +00:00

glow referenced this issue from a commit

2026-06-10 10:31:06 +00:00

fix: resolve 5 agenda-plugin issues — loading, cache keys, change detection, decisions, config path