P3-02: port=0 silently overwritten to 8655 — "random port" use case broken #20

New issue

Closed

opened 2026-06-16 13:57:02 +00:00 by Artur · 0 comments

Artur commented

2026-06-16 13:57:02 +00:00

Owner

Severity: P3 (Low)
File: decider/config.py line 123

Problem

if not cfg.get("server", {}).get("port"):
    logger.warning("server.port missing or invalid, defaulting to 8655")
    cfg.setdefault("server", {})["port"] = 8655

port=0 is a valid use case ("OS picks a random port"), but not 0 is True, so it gets silently overwritten.

Fix

Check for None or missing key explicitly, not falsiness:

port = cfg.get("server", {}).get("port")
if port is None:
    ...

**Severity**: P3 (Low) **File**: `decider/config.py` line 123 ## Problem ```python if not cfg.get("server", {}).get("port"): logger.warning("server.port missing or invalid, defaulting to 8655") cfg.setdefault("server", {})["port"] = 8655 ``` `port=0` is a valid use case ("OS picks a random port"), but `not 0` is `True`, so it gets silently overwritten. ## Fix Check for `None` or missing key explicitly, not falsiness: ```python port = cfg.get("server", {}).get("port") if port is None: ... ```

Artur added the

bug

P3-Low

labels

2026-06-16 13:57:02 +00:00

Artur referenced this issue from a commit

2026-06-16 13:59:15 +00:00

fix: P2-01, P2-04, P3-01, P3-02, P3-03, P3-04, P3-05

Artur closed this issue

2026-06-16 14:24:07 +00:00